SILOptimizer: Make some analysis caches lazy #68233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
tshortli
changed the title
ClassHierarchyAnalysis and ProtocolConformanceAnalysis lazy
|
Would it be a lot of work to refactor these to use requests? |
When serializing modules with `-experimental-skip-all-function-bodies`, this analysis was eagerly populating a cache that would go unused since there is no optimization to do. With `-experimental-lazy-typecheck`, this work would also trigger unnecessary typechecking requests. NFC.
When serializing modules with `-experimental-skip-all-function-bodies`, this analysis was eagerly populating a cache that would go unused since there is no optimization to do. With `-experimental-lazy-typecheck`, this work would also trigger unnecessary typechecking requests. NFC.
tshortli
force-pushed
the
lazier-sil-optimizer-analysis
branch
from
df8de5f to
255d5d4
Compare
|
@swift-ci please smoke test |
I'd like to prioritize working on what this is unblocking but I've left a note indicating that these could be made requests in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When serializing modules with
-experimental-skip-all-function-bodies, theClassHierarchyAnalysisandProtocolConformanceAnalysisanalyses were eagerly populating caches that would go unused since there is no optimization to do when there are no SIL function bodies. With-experimental-lazy-typecheck, this work would also trigger unnecessary typechecking requests. NFC.