Skip to content

Introduce and use COMPILER_IS_MSVC #6828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2017
Merged

Introduce and use COMPILER_IS_MSVC #6828

merged 1 commit into from
Jan 16, 2017

Conversation

hughbe
Copy link
Contributor

@hughbe hughbe commented Jan 15, 2017

  • Simplifies the areas we check for MSVC specific behaviour.
  • I've extracted this out to a new file Compiler.h, as I'll add more compiler specific definitions, such as for deleted delete operator and the trailing objects bugs

@jckarter FYI, this is the start of implementing your suggestion

@slavapestov
Copy link
Contributor

@swift-ci Please smoke test

@slavapestov slavapestov self-assigned this Jan 15, 2017
@slavapestov slavapestov merged commit 48da014 into swiftlang:master Jan 16, 2017
@hughbe hughbe deleted the compiler-is-msvc branch January 16, 2017 08:16
@hughbe hughbe mentioned this pull request Jan 16, 2017
Merged
@jckarter
Copy link
Contributor

Please change the name to SWIFT_COMPILER_IS_MSVC or similar. Preprocessor macros should be namespaced.

@hughbe
Copy link
Contributor Author

hughbe commented Jan 16, 2017

Sorry, updated in #6837

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@slavapestov slavapestov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hughbe @slavapestov @jckarter