[semantic-sil] ObjC metatypes as metatypes are trivial. Only once converted to objects do they have @owned ownership. #6833
Conversation
…verted to objects do they have @owned ownership. This commit cleans up a few places in bridging code, where we were treating metatypes as if they had non-invalid cleanups. rdar://29791263
|
@jckarter I believe I am correct here. But I would like to just double/triple check that I am correct about the objc metatypes. |
|
@swift-ci Please test |
|
Also, I have been reading this code for a little bit. It is incredibly misleading and borderline incorrect. We have just been getting lucky since objective-c initializers will take their parameter at +1. So even though we were writing code as if the metatype had a cleanup and were passing through the cleanup (which was not anything). If we were not always passing the alloc_ref_dynamic into an initializer, we definitely would have a leak since a destroy would never have been inserted. |
|
Actually, after reading this more and thinking about the change. I feel comfortable committing it. But still a second pair of eyes, can't hurt. |
[semantic-sil] ObjC metatypes as metatypes are trivial. Only once converted to objects do they have @owned ownership.
This commit cleans up a few places in bridging code, where we were treating
metatypes as if they had non-invalid cleanups.
rdar://29791263