[MoveChecker] Complete lifetimes before checking. #68342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-chandler
force-pushed
the
gh68328
branch
2 times, most recently
from
0efb5ec to
a50b875
Compare
nate-chandler
changed the title
nate-chandler
changed the title
meg-gupta
reviewed
Sep 6, 2023
meg-gupta
reviewed
Sep 6, 2023
meg-gupta
reviewed
Sep 6, 2023
nate-chandler
force-pushed
the
gh68328
branch
from
a50b875 to
b8a261f
Compare
Before move-checking values, complete the lifetimes of all the values derived from them via copy, borrow, and move. Collect all such values and their derived transitive values and then complete the lifetimes of each, visiting the instructions which produce them in post-order. Once OSSALifetimeCommpletion runs as part of SILGenCleanup, this code can be deleted.
nate-chandler
force-pushed
the
gh68328
branch
from
b8a261f to
7713eef
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please benchmark |
|
Failures in match failures in baseline: https://ci.swift.org/job/swift-PR-source-compat-suite-macos/1138/artifact/swift-source-compat-suite/ match failures in baseline: https://ci.swift.org/job/swift-main-source-compat-suite-debug/537/artifact/swift-source-compat-suite/ |
|
LGTM! |
This was referenced Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before move-checking values, complete the lifetimes of all the values derived from them via copy, borrow, move, and phi.
Collect all such values and their derived transitive values and then complete the lifetimes of each, visiting the instructions which produce them in post-order.
Once OSSALifetimeCompletion runs as part of SILGenCleanup, this code can be deleted.