Revert optional breakage #6835
Merged
Revert optional breakage #6835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1efafbc because results in a regression in source compatibility with Swift 3. It also adds a test demonstrating what was broken by the change. I will take another look at fixing the exponential behavior that this was attempting to fix. Fixes rdar://problem/29977523.
|
@DougGregor FYI - backing out the performance improvement for collection type checking due to the source compatibility break. I have some ideas on how to get the performance improvement back which I will take a look at when I get a chance. |
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert a change that improved performance of type checking but resulted in a regression in source compatibility.