swift-plugin-server: remove standard headers #68357
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redefine the types rather than use the standard headers due to the circular dependency between Darwin and Swift.
|
@swift-ci please test |
rintaro
reviewed
Sep 6, 2023
tools/swift-plugin-server/Sources/CSwiftPluginServer/include/PluginServer.h
Show resolved
Hide resolved
|
@swift-ci please test |
rintaro
reviewed
Sep 6, 2023
Comment on lines
35
to
98
| size_t PluginServer_read(const void *connHandle, void *data, size_t nbyte); | ||
| SwiftUInt PluginServer_read(const void *connHandle, void *data, SwiftUInt nbyte); | ||
|
|
||
| /// Write bytes to the IPC communication handle. | ||
| size_t PluginServer_write(const void *connHandle, const void *data, size_t nbyte); | ||
| SwiftUInt PluginServer_write(const void *connHandle, const void *data, SwiftUInt nbyte); |
There was a problem hiding this comment.
read and write can return negative values, so I believe we should use SwiftInt for the return values. For arguments, I don't really care, but you changed them to cast to Int https://github.com/apple/swift/pull/68268/files#diff-767b2b406807fd466b462821427b84772bdb1ddd27f3bea3781df7ec490ef2daL175-R196 So I think this should be SwiftInt as well?
|
@swift-ci Please smoke test |
|
Moving to #68377 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redefine the types rather than use the standard headers due to the circular dependency between Darwin and Swift.