Disable a few mark_dependence sil combines in ossa #68395
Merged
+95
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci apple silicon benchmark |
|
@swift-ci test |
There are 2 reasons to disable this: 1. OSSA rauw creates copies for replacement, copies created in this case cannot be canonicalized away due to the presence of pointer escape. (See test test_mark_dependence_ossa_silcombine1 after -sil-combine -copy-propagation) 2. SILCombine of mark_dependence (enum can cause a potential miscompile. ClosureLifetimeFixup specifically inserts enums to lifetime extend the closure lifetime until the end of the function. Replacing mark_dependence's base operand with a copy of the enum's operand can end up shortening the lifetime of the base. (See test test_mark_dependence_ossa_silcombine2 after -sil-combine -dce -semantic-arc-opts)
|
@swift-ci smoke test |
atrick
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 reasons to disable this:
OSSA rauw creates copies for replacement, copies created in this case cannot be canonicalized away due to the presence of pointer escape. (See test
test_mark_dependence_ossa_silcombine1after-sil-combine -copy-propagation)SILCombine of mark_dependence (enum can cause a potential miscompile.
ClosureLifetimeFixup specifically inserts enums to lifetime extend the closure lifetime until the end of the function. Replacing mark_dependence's base operand with a copy of the enum's operand can end up shortening the lifetime of the base. (See test
test_mark_dependence_ossa_silcombine2after-sil-combine -dce -semantic-arc-opts)Fixes rdar://115139907 and rdar://114615539