[5.9] Ensure module tracing is off when checking disable-implicit* …
#68455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flags In some internal configurations we set the `SWIFT_LOADED_MODULE_TRACE_FILE` environment variable when running the build of the compiler -- as a result, this causes `-parse` to always fails, preventing to detect properly if we can use `disable-implicit*` flags. Addresses rdar://115338219 (cherry picked from commit ec49873)
|
@swift-ci please test |
al45tair
approved these changes
Sep 12, 2023
tbkka
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…flags
In some internal configurations we set the
SWIFT_LOADED_MODULE_TRACE_FILEenvironment variable when running the build of the compiler -- as a result, this causes-parseto always fails, preventing to detect properly if we can usedisable-implicit*flags.(cherry picked from commit ec49873)
Explanation: explicitly unset
SWIFT_LOADED_MODULE_TRACE_FILEwhen detecting if the Swift compiler supporstdisable-implicit*flags -- this is to prevent the-parseinvocation we use for such detection to fail unconditionallyRadar: rdar://115338219
Scope: build logic used to detect if the compiler supports
disable-implicit*Risk: low
SWIFT_LOADED_MODULE_TRACE_FILEis mostly used in internal configuration, and should not affect opensourceTesting: run a local Darwin build setting
SWIFT_LOADED_MODULE_TRACE_FILEmanually, checked that thedisable-implicitflags are correctly used during builds of the compilerReviewed by: