Skip to content

[build-script] Install 'earlyswiftsyntax' if 'install-swift' is off #68462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Sep 12, 2023

Some build scenario (e.g. lldb) want swift-syntax libraries installed but don't want to install "swift" compiler products.

Install earlyswiftsyntax products independently when --install-swiftsyntax is specified but --install-swift is NOT specified.

@rintaro rintaro requested a review from bnbarham September 12, 2023 17:54
@rintaro
Copy link
Member Author

rintaro commented Sep 12, 2023

@swift-ci Please smoke test

@rintaro rintaro force-pushed the buildscript-install-earlyswiftsyntax branch from 6d8742c to e044380 Compare September 12, 2023 18:31
@rintaro
Copy link
Member Author

rintaro commented Sep 12, 2023

@swift-ci Please smoke test

1 similar comment
@rintaro
Copy link
Member Author

rintaro commented Sep 12, 2023

@swift-ci Please smoke test

@rintaro rintaro force-pushed the buildscript-install-earlyswiftsyntax branch from e044380 to 522079e Compare September 12, 2023 18:40
Some build scenario (e.g. lldb) want swift-syntax libraries installed
but don't want to install "swift" compiler products.

Install 'earlyswiftsyntax' products independently when
'--install-swiftsyntax' is specified but '--install-swift' is NOT
specified.
@rintaro rintaro force-pushed the buildscript-install-earlyswiftsyntax branch from 522079e to 466eb9a Compare September 12, 2023 18:53
@rintaro
Copy link
Member Author

rintaro commented Sep 12, 2023

@swift-ci Please smoke test

@rintaro
Copy link
Member Author

rintaro commented Sep 12, 2023

@swift-ci Please smoke test Windows

@rintaro rintaro merged commit 222e8b7 into swiftlang:main Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants