Skip to content

[5.9] [Test] Reenabled xfail'd test. #68464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2023
Merged

[5.9] [Test] Reenabled xfail'd test. #68464

merged 1 commit into from
Sep 13, 2023

Conversation

hamishknight
Copy link
Contributor

@hamishknight hamishknight commented Sep 12, 2023 •
edited
Loading

5.9 cherry-pick of #68176

  • Explanation: Remove an XFAIL for a test that's now passing on that configuration
  • Scope: Test-only change
  • Issue: rdar://65399527
  • Risk: None
  • Testing: Added tests to test suite
  • Reviewer: Nate Chandler

@nate-chandler @hamishknight
[Test] Reenabled xfail'd test.
08564f9 
The test
`test/attr/attr_originally_definedin_backward_compatibility.swift` is
passing now.
@hamishknight hamishknight requested a review from a team as a code owner September 12, 2023 19:22
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@bnbarham
Copy link
Contributor

Any idea what caused this to now pass?

@hamishknight hamishknight merged commit c463c69 into swiftlang:release/5.9 Sep 13, 2023
@hamishknight hamishknight deleted the 68176-5.9 branch September 13, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

@nate-chandler nate-chandler nate-chandler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hamishknight @bnbarham @nate-chandler