[interop] do not synthesize special members for C++ records with inco… #68478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplete fields The incomplete fields will trigger different assertions when clang is sythensizing constructors/destructors rdar://109417079 (cherry picked from commit 786c78a)
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
DougGregor
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mplete fields
The incomplete fields will trigger different assertions when clang is sythensizing constructors/destructors
rdar://109417079
(cherry picked from commit 786c78a)
Explanation: LLDB during debugging Swift code with enabled C++ interop can sometimes import a type that contains a field with an incomplete type. This leads to crashes in Clang when it tries to check if it can generate a destructor/copy constructor. This change adds a check to the clang importer to avoid generating special members like destructors and copy constructors when importing types with incomplete fields.
Issue: rdar://109417079
Risk: Low, this does not reproduce in compiled code.
Testing: Modified existing unit tests, verified no regressions in unit tests and some adopters, verified LLDB issue resolved.
Reviewer: @zoecarver
Original PR: #68383