Skip to content

[embedded] Fix compiler crash in getRuntimeEffect when processing ExistentialMetatypeInst #68500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2023
Merged

[embedded] Fix compiler crash in getRuntimeEffect when processing ExistentialMetatypeInst #68500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions lib/SIL/Utils/InstructionUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,11 +806,21 @@ RuntimeEffect swift::getRuntimeEffect(SILInstruction *inst, SILType &impactType)
case ExistentialRepresentation::Opaque:
return RuntimeEffect::MetaData;
case ExistentialRepresentation::Class: {
if (opType.isAnyObject()) {
if (inst->getModule().getASTContext().LangOpts.EnableObjCInterop) {
return RuntimeEffect::MetaData | RuntimeEffect::Existential |
RuntimeEffect::ObjectiveC;
} else {
return RuntimeEffect::MetaData | RuntimeEffect::Existential;
}
}
auto *cl = opType.getClassOrBoundGenericClass();
bool usesObjCModel = cl->getObjectModel() == ReferenceCounting::ObjC;
if ((cl && usesObjCModel) || opType.isAnyObject())
return RuntimeEffect::MetaData | RuntimeEffect::ObjectiveC;
return RuntimeEffect::MetaData | RuntimeEffect::ObjectiveC;
bool usesObjCModel =
cl && cl->getObjectModel() == ReferenceCounting::ObjC;
if (usesObjCModel)
return RuntimeEffect::MetaData | RuntimeEffect::ObjectiveC |
RuntimeEffect::Existential;
return RuntimeEffect::MetaData | RuntimeEffect::Existential;
}
case ExistentialRepresentation::None:
return RuntimeEffect::NoEffect;
Expand Down
18 changes: 18 additions & 0 deletions test/embedded/anyobject-error-no-stdlib.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
// RUN: %target-swift-emit-ir -parse-stdlib %s -enable-experimental-feature Embedded -verify

public enum Never {}

@_silgen_name("abort")
func abort() -> Never

@_semantics("typechecker.type(of:)")
public func type<T, Metatype>(of value: T) -> Metatype { abort() }

public typealias AnyObject = Builtin.AnyObject

precedencegroup AssignmentPrecedence { assignment: true }

public func foo(_ x: AnyObject) {
_ = type(of: x) // expected-error {{existential can cause metadata allocation or locks}}
// expected-note@-1 {{called from here}}
}