[Parse] Disallow unsupported condition expression in #if directive #6855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In non-Swift3 mode. Previously: #if FOO = false #elseif FOO ? false : true #endif were silently accepted. i.e. '= false' and '? false : true' were silently ignored.
rintaro
commented
Jan 17, 2017
| diag::unsupported_conditional_compilation_expression_type); | ||
| return ConditionalCompilationExprState::error(); | ||
| } else { | ||
| // TODO: Emit a warning. |
There was a problem hiding this comment.
Any suggestion for the message?
warning: ignoring invalid conditional compilation expression, which will be rejected in future version of Swift
#if FOO ? BAR : BAZ && QUX
^~~~~~~~~~~
will be OK?
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
slavapestov
reviewed
Jan 17, 2017
| @@ -1356,6 +1356,9 @@ ERROR(unexpected_version_comparison_operator,none, | |||
| ()) | |||
| ERROR(unsupported_conditional_compilation_expression_type,none, | |||
| "invalid conditional compilation expression", ()) | |||
| WARNING(swift3_unsupported_conditional_compilation_expression_type,none, | |||
There was a problem hiding this comment.
Nitpick: align whitespace on next line with (
rintaro
force-pushed
the
parse-ifconfig-invalid-binary
branch
from
185f808 to
b2d549e
Compare
|
@swift-ci Please smoke test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In non-Swift3 mode.
Previously:
were silently accepted.
i.e.
= falseand? false : truewere silently ignored.In Swift3 mode, emit a warning: