Skip to content

test: adjust tests for Windows after the rebranch #68553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

compnerd
Copy link
Member

This corrects the name decoration and splits the windows and itanium decoration schemes. This allows us to un-XFAIL some of the interop tests on Windows while repairing the failures identified on rebranch.

This corrects the name decoration and splits the windows and itanium
decoration schemes.  This allows us to un-XFAIL some of the interop
tests on Windows while repairing the failures identified on rebranch.
@etcwilde
Copy link
Member

@swift-ci please smoke test

@etcwilde
Copy link
Member

Linux is still hitting the expected clang/DebugInfo crash.
Windows is down from 6 failures to 4 failures;

Failed Tests (4):
  Swift(windows-x86_64) :: DebugInfo/implicitreturn.swift
  Swift(windows-x86_64) :: Driver/Dependencies/only-skip-once.swift
  Swift(windows-x86_64) :: IRGen/c_globals.swift
  Swift(windows-x86_64) :: IRGen/framepointer.sil

This fixes

  Swift(windows-x86_64) :: Interop/Cxx/operators/member-inline-irgen.swift
  Swift(windows-x86_64) :: Interop/Cxx/operators/member-out-of-line-irgen.swift

This all makes sense given the changes. Recording for the sake of tracking.

macOS is somehow still building llvm after 3 hours, but I'd like to verify that it doesn't break these two tests before merging.

@etcwilde
Copy link
Member

macOS failure

********************
Failed Tests (1):
  lldb-api :: lang/swift/async/stepping/step-in/TestSwiftStepInAsync.py

********************
Unexpectedly Passed Tests (1):
  lldb-api :: lang/swift/async/stepping/step-in/task-switch/TestSwiftTaskSwitch.py

@compnerd
Copy link
Member Author

compnerd commented Oct 3, 2023

@swift-ci please test

@etcwilde
Copy link
Member

etcwilde commented Oct 3, 2023

All failures are known and expected. Merging.

@etcwilde etcwilde merged commit 5dd609a into swiftlang:rebranch Oct 3, 2023
@compnerd compnerd deleted the unxfail branch October 3, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants