Skip to content

[Concurrency] Remove ClosureActorIsolation. #68567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 17, 2023

Conversation

hborla
Copy link
Member

@hborla hborla commented Sep 16, 2023

This change removes ClosureActorIsolation and replaces all uses with ActorIsolation. ActorIsolation can now store a VarDecl to directly represent an actor instance when the actor isolation kind is ActorIsolation::ActorInstance, which is currently always used for closures isolated to actor instances. This is the first step toward unifying the isolation computation for closures and local functions.

getClosureActorIsolation.

This is preparation for changing AbstractClosureExpr to store
ActorIsolation instead of ClosureActorIsolation, and convert to
ClosureActorIsolation when needed to allow incrementally updating
callers. This change is NFC.
@hborla
Copy link
Member Author

hborla commented Sep 16, 2023

@swift-ci please test

Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, LGTM 👍

@hborla
Copy link
Member Author

hborla commented Sep 17, 2023

@swift-ci please smoke test

@hborla hborla merged commit 9f225d6 into swiftlang:main Sep 17, 2023
@hborla hborla deleted the unify-actor-isolation branch September 17, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants