[embedded] Detect WMO via .hasPrimaryInputs() instead of -wmo flag presence #68568
Conversation
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
lib/Frontend/CompilerInvocation.cpp
Outdated
| @@ -1323,6 +1323,11 @@ static bool ParseLangArgs(LangOptions &Opts, ArgList &Args, | |||
| Diags.diagnose(SourceLoc(), diag::evolution_with_embedded); | |||
| HadError = true; | |||
| } | |||
|
|
|||
| if (FrontendOpts.InputsAndOutputs.hasPrimaryInputs()) { | |||
There was a problem hiding this comment.
I don’t really understand this. Primaries and WMO don’t really mix. Are you trying to detect the optimization mode, or the compilation mode?
There was a problem hiding this comment.
Thanks for chiming in here, I could use some help with this :)
What I’m trying to do is to require WMO, the compilation mode. I thought that the presense of a primary file is a clear sign that we’re not doing WMO (and vice versa). Is that not true?
|
WMO checking is already done by #68358, right? |
|
Yes, but I realized that the -wmo flag is a flag for the driver, and not for the frontend. So #68358 isn't going to work if we actually compile with the driver (the driver doesn't pass it down to the frontend). This is the whole point of this PR, I should have started with stating that, sorry! :) |
kubamracek
force-pushed
the
embedded-wmo-via-primaryfiles
branch
from
073930b to
d2f8530
Compare
|
@swift-ci please test and merge |
No description provided.