[CodeCompletion] Completion for @storageRestrictions attribute
#68603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
bnbarham,
rintaro,
hamishknight,
CodaFi and
DougGregor
as code owners
|
@swift-ci Please smoke test |
hamishknight
approved these changes
Sep 19, 2023
ahoppen
force-pushed
the
ahoppen/storage-attribute-completion
branch
from
04209e3 to
2c41e11
Compare
xedin
approved these changes
Sep 22, 2023
|
@swift-ci Please smoke test |
ahoppen
force-pushed
the
ahoppen/storage-attribute-completion
branch
from
2c41e11 to
39d450e
Compare
|
@swift-ci Please smoke test |
ahoppen
force-pushed
the
ahoppen/storage-attribute-completion
branch
from
39d450e to
712d3e2
Compare
|
@swift-ci Please smoke test |
|
@hamishknight @xedin I added one more patch commit to this PR. Could you give it a quick review? 712d3e2 |
xedin
approved these changes
Sep 27, 2023
| get { 1 } | ||
| } | ||
| // FIRST_ARGUMENT: Begin completions, 1 item | ||
| // FIRST_ARGUMENT-DAG: Decl[InstanceVar]/CurrNominal: other[#Int#]; |
There was a problem hiding this comment.
Might make sense to add one more test here that checks "accesses:" as well for completeness.
hamishknight
approved these changes
Sep 27, 2023
ahoppen
force-pushed
the
ahoppen/storage-attribute-completion
branch
from
712d3e2 to
17e6a25
Compare
…ge()` to determine if a variable is stored This uncovered a discrepancy between `getImplInfo().hasStorage()` and `hasStorage()`.
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offer
storageRestrictionsafter@initializesandaccesseslabels inside@storageRestrictionsinitializesandaccesseslabelsrdar://115501026