Avoid issuing warning when user lib implements only ExecutorJob enqueue #68617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latter example NIODefaultSerialEventLoopExecutor when the type is more available than the enqueue implementation provided via an extrension would issue a warning that that this enqueue(ExecutorJob) would not be used which is not true. We need to filter out all "default impls" from the stdlib as we issue this warning. We also put a note on the offending declaration that one can remove now, to ease getting rid of warnings when possible Resolves rdar://115166475
ktoso
requested review from
kavon,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
ktoso
added
the
concurrency
ktoso
commented
Sep 19, 2023
| @available(macOS 14.0, iOS 17.0, watchOS 10.0, tvOS 17.0, *) | ||
| extension NIODefaultSerialEventLoopExecutor: SerialExecutor { | ||
| @inlinable | ||
| public func enqueue(_ job: consuming ExecutorJob) { // do NOT issue a warning here |
There was a problem hiding this comment.
in the meantime tbh you can implement the UnownedJob version to avoid warnings; they're effectively the same nowadays. @FranzBusch
There was a problem hiding this comment.
Don't we get deprecation warnings when adding the UnownedJob implementation?
There was a problem hiding this comment.
Hm, the deprecation only is when you'd call the method though right? The test confirms there are no warnings issued here 🤔 The UnownedJob itself is not deprecated.
And you could technically mark your enqueue impl as deprecated as well actually
|
@swift-ci please build toolchain macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latter example NIODefaultSerialEventLoopExecutor when the type is more available than the enqueue implementation provided via an extension would issue a warning that that this enqueue(ExecutorJob) would not be used which is not true.
We need to filter out all "default impls" from the stdlib as we issue this warning.
We also put a note on the offending declaration that one can remove now, to ease getting rid of warnings when possible
I believe this manifests only on macOS where the availability comes into play -- @FranzBusch can confirm from NIO CI.
Resolves rdar://115166475