[Verifier] ObjC protocols may have unavailable requirements #6862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...which don't need to have witnesses. I can't seem to come up with a reduced test case for this one, but it does fix a verifier failure in the larger project that triggered this. rdar://problem/29744313
|
@slavapestov, @DougGregor, any ideas how to test this? Or any ideas why this reduced case passed the verifier? import Foundation
open class Test : NSObject, NSCoding {
public override init() { fatalError() }
public required init?(coder: NSCoder) { fatalError() }
open func encode(with coder: NSCoder) { fatalError() }
}import Lib
import Foundation
final class Sub: Test {}@swift-ci Please smoke test |
|
I guess that's also a review request, since we'll want to cherry-pick this to the 3.1 branch. |
|
Do non-objc protocols ever have unavailable requirements? |
|
I imagine we'll start wanting them for renaming purposes, but in that case I think we probably still require a witness; it'll just be a forwarding witness in an unconstrained protocol extension. |
|
…but currently they do not. |
|
Known failure in Foundation (dependent commits merged out of order). Will restart testing later. |
|
@swift-ci Please smoke test Linux |
|
Oh, LGTM too |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Jan 18, 2017
…ng#6862) ...which don't need to have witnesses. I can't seem to come up with a reduced test case for this one, but it does fix a verifier failure in the larger project that triggered this. rdar://problem/29744313
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...which don't need to have witnesses.
I can't seem to come up with a reduced test case for this one, but it does fix a verifier failure in the larger project that triggered this, where it complained about NSCoder's
encodeWithCoder(_:)method (which was renamed toencode(with:)in Swift 3).rdar://problem/29744313