Sema: Partial revert of #67939 [5.9] #68632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it is source-breaking with existing code, we decided not to take the TypeAliasType fix for the 5.9 branch.
slavapestov
force-pushed
the
revert-referenced-generic-param-fix-5.9
branch
from
9873411 to
67d59a5
Compare
|
@swift-ci Please test |
hborla
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: We require that a generic function mentions all generic parameters in its interface type, so that the solver can actually bind them when type checking a call to a function. PR Sema: Fix two problems in checkReferencedGenericParams() analysis [5.9] #67939 fixed a bug in this analysis with parameter packs and type aliases. The second part of the fix was source breaking, so we decided not to take it in 5.9.
Risk: None.
Reviewed by: @hborla