Skip to content

[embedded] Make StaticString versions assert/precondition/fatalError available in embedded Swift #68654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2023
Merged

[embedded] Make StaticString versions assert/precondition/fatalError available in embedded Swift #68654

merged 1 commit into from
Sep 21, 2023

Conversation

kubamracek
Copy link
Contributor

No description provided.

@kubamracek
Copy link
Contributor Author

@swift-ci please test

phausler
phausler approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@phausler phausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this have an else to the normal definitions?

@kubamracek
Copy link
Contributor Author

The normal definitions are "@_unavailableInEmbedded" above, that seems to work...

@kubamracek kubamracek added the embedded Embedded Swift label Sep 20, 2023
@kubamracek kubamracek merged commit c751b62 into swiftlang:main Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phausler phausler phausler approved these changes

@zoecarver zoecarver Awaiting requested review from zoecarver

Assignees
No one assigned
Labels
embedded Embedded Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kubamracek @phausler