[5.10 🍒][Dependency Scanning] Process implicit imports of the source module first, emulating implicit builds #68678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
nkcsgexi
reviewed
Sep 21, 2023
| } | ||
| } | ||
|
|
||
| // Add user-specified `import` dependencies |
There was a problem hiding this comment.
Could you add some comments about that this needs to happen after implicit imports?
nkcsgexi
approved these changes
Sep 21, 2023
artemcm
force-pushed
the
510FixImportProcessOrderForScan
branch
from
2f4785b to
63994e0
Compare
|
@swift-ci test and merge |
…irst, emulating implicit builds In case import resolution order somehow sometimes matters, it's prudent to process/resolve/locate implicitly-imported modules first. Resolves rdar://113917657
artemcm
force-pushed
the
510FixImportProcessOrderForScan
branch
from
63994e0 to
6614058
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #68677
• Release: Swift 5.10
• Explanation: In case import resolution order somehow sometimes matters, it's prudent to process/resolve/locate implicitly-imported modules first.
• Scope of Issue: Some projects which rely on import order-dependent behavior for Clang module resolution may be affected and see different behavior with explicit module builds.
• Risk: Minimal, this changes explicit module dependency scanning code-path only to match the behavior currently exercise by implicit module builds
• Origination: Explicit Module Build feature development. Scanner's default order of module resolution unintentionally differed from implicit module flow.
Resolves rdar://113917657