Skip to content

[CI] fix test when asserts are off #68707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kavon
Copy link
Member

@kavon kavon commented Sep 22, 2023

For some reason, this test was failing in the configuration oss-swift_tools-R_stdlib-RD_test-simulator, which is a build with no asserts and run in a simulator.

This refactoring of the RUN line magically fixes it.

rdar://115881645

For some reason, this test was failing in the configuration
`oss-swift_tools-R_stdlib-RD_test-simulator`, which is a
build with no asserts and run in a simulator.

This refactoring of the RUN line magically fixes it.

rdar://115881645
@kavon
Copy link
Member Author

kavon commented Sep 22, 2023

@swift-ci please smoke test

@kavon
Copy link
Member Author

kavon commented Sep 22, 2023

preset=buildbot,tools=R,stdlib=RD
@swift-ci Please test with preset macOS

@slavapestov
Copy link
Contributor

@kavon experimental features are not available in noassert builds, see #68706 for @NuriAmari's fix

@kavon
Copy link
Member Author

kavon commented Sep 22, 2023

Huh, well it works in non-asserts builds when you pass -verify. I tested this change locally with non-asserts, and the other test using the feature doesn't require asserts and isn't failing in CI:

test/Constraints/copyable_requirement.swift
1:// RUN: %target-typecheck-verify-swift -enable-experimental-feature NoncopyableGenerics

@kavon kavon closed this Sep 22, 2023
@kavon kavon deleted the fix-inverse-constraints-test branch September 22, 2023 19:59
@kavon
Copy link
Member Author

kavon commented Sep 22, 2023

I figured out what the magic was with -typecheck -verify: #68711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants