[ASTGen] Use standard headers in bridging interface #68710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
requested review from
zoecarver,
CodaFi,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci Please smoke test |
bnbarham
reviewed
Sep 22, 2023
| long long JSON_array_getSize(void *arrayPtr); | ||
| void *JSON_array_getValue(void *arrayPtr, long long index); | ||
| size_t JSON_array_getSize(void *arrayPtr); | ||
| void *JSON_array_getValue(void *arrayPtr, size_t index); |
There was a problem hiding this comment.
Should this be int64_t or was long long wrong?
There was a problem hiding this comment.
This is an index of the array element, since the argument of the operator[] is size_t, I thought we should use it.
There was a problem hiding this comment.
I really meant both here - ie. both the getSize and the getValue. If it's the right thing, sure. I mostly just went through and checked for any inconsistencies.
rintaro
force-pushed
the
macros-darwin-swift
branch
from
ead7317 to
51c0829
Compare
|
@swift-ci Please smoke test |
rintaro
force-pushed
the
macros-darwin-swift
branch
from
51c0829 to
bfcf756
Compare
|
@swift-ci Please smoke test |
rintaro
force-pushed
the
macros-darwin-swift
branch
from
bfcf756 to
42256b1
Compare
|
@swift-ci Please smoke test |
bnbarham
approved these changes
Sep 25, 2023
rintaro
force-pushed
the
macros-darwin-swift
branch
from
42256b1 to
292e76d
Compare
|
@swift-ci Please smoke test |
rintaro
force-pushed
the
macros-darwin-swift
branch
from
292e76d to
5f730f9
Compare
|
@swift-ci Please smoke test |
For whatever reason, using standard headers in modules imported from Swift code (depending on Darwin overlay) is no longer an issue.
For whatever reason, using standard headers in modules imported from Swift code (i.e. depending on Darwin overlay) is no longer an issue. rdar://115438609
rintaro
force-pushed
the
macros-darwin-swift
branch
from
5f730f9 to
7ac5d65
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatever reason, using standard headers in clang modules imported from Swift code (i.e. depending on Darwin overlay) is no longer an issue.
rdar://115438609