[isolation-regions] Eliminate unnecessary heap allocations used for temporary values #68712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…slation loop. I did this by introducing a builder construct that has a SmallVector within it that we append into instead of returning std::vector. I also used some passed in SmallVectors in other places as well with large enough sizes that most times we will not allocate.
…he non-error path.
Transfer is the terminology that we are using for something be transferred across an isolation boundary, not consume. This also eliminates confusion with consume which is a term being used around ownership.
|
@swift-ci smoke test |
slavapestov
approved these changes
Sep 26, 2023
|
|
||
| struct PartitionOpBuilder { | ||
| /// Parent translator that contains state. | ||
| PartitionOpTranslator *translater; |
There was a problem hiding this comment.
Nitpick: translator not translater
There was a problem hiding this comment.
I'll fix this in a follow on.
| return {}; | ||
| void getApplyResults(const SILInstruction *inst, | ||
| SmallVectorImpl<SILValue> &foundResults) { | ||
| if (isa<ApplyInst, BeginApplyInst, BuiltinInst, PartialApplyInst>(inst)) { |
There was a problem hiding this comment.
Whoa I didn't know isa<> was variadic
There was a problem hiding this comment.
(I didn't know either)
| // PartitionOpKind represents the different kinds of PartitionOps that | ||
| // SILInstructions can be translated to | ||
| /// PartitionOpKind represents the different kinds of PartitionOps that | ||
| /// SILInstructions can be translated to |
There was a problem hiding this comment.
It might help if the comments for each case gave an example of an actual instruction that lowers to this operation?
There was a problem hiding this comment.
I'll add that in a follow on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am splitting this off of a different commit that I decided to do in a slightly different manner. This PR just eliminates all of the temporary std::vectors being passed around in the hot loop of the pass in favor of a builder type that stores internally a SmallVector that should be large enough for handling the PartitionOps produced by any instruction.