[embedded] Make CMO's 'serialize everything' mode even more aggressive and allow serialization of private and shared functions #68727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and allow serialization of private and shared functions
kubamracek
requested review from
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a (more) complete "alwaysEmitIntoClient" model on the module serialization side for embedded Swift as mentioned in https://github.com/apple/swift-evolution/blob/488e96672f2f54bbe0716dfe63cc5df753c3436f/visions/embedded-swift.md. Currently, CMO's serialization is still excluding several kinds of functions from being serialized (even in the "full" serialization mode), and that is problematic for embedded Swift. One concrete case is shown in an added testcase, where a specialization of a function from the stdlib is not serialized and ends up missing on the library client side and causes a link failure. The PR adds a real "serialize everything" mode to CMO and turns that on for embedded Swift.
Take 2, first attempt caused a SILVerifier failure and was reverted.