Skip to content

add missing asserts guard to tests using experimental features #68730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kavon
Copy link
Member

@kavon kavon commented Sep 23, 2023

@kavon
Copy link
Member Author

kavon commented Sep 23, 2023

@swift-ci smoke test and merge

@kavon kavon changed the title add missing asserts guard to test using experimental feature add missing asserts guard to tests using experimental features Sep 24, 2023
When using an experimental feature that is not available
in production, a test needs to have `REQUIRES: asserts`
so that non-assert builds don't unexpectedly fail.
@kavon kavon force-pushed the assertGuard-experimental-noncopyablegenerics branch from 6a7a71e to a69f9e4 Compare September 24, 2023 02:55
@kavon kavon marked this pull request as ready for review September 24, 2023 02:56
@kavon
Copy link
Member Author

kavon commented Sep 24, 2023

@swift-ci smoke test and merge

@swift-ci swift-ci merged commit 8f5fbf3 into swiftlang:main Sep 24, 2023
@kavon kavon deleted the assertGuard-experimental-noncopyablegenerics branch September 24, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants