Skip to content

Revert "🍒[cxx-interop] Look up NSNotificationName in C++ language mode properly" #68746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2023
Merged

Revert "🍒[cxx-interop] Look up NSNotificationName in C++ language mode properly" #68746

merged 1 commit into from
Sep 29, 2023

Conversation

egorzhdan
Copy link
Contributor

@egorzhdan egorzhdan commented Sep 25, 2023 •
edited by bnbarham
Loading

  • Explanation: Reverts commit e956e8a as it causes some issues in existing adopters.
  • Scope: C++ interop.
  • Risk: Low, revert of an existing change.
  • Testing: Existing tests.

rdar://115424525

@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Sep 25, 2023
@egorzhdan egorzhdan requested a review from a team as a code owner September 25, 2023 19:12
@egorzhdan
Copy link
Contributor Author

@swift-ci please test

@bnbarham bnbarham merged commit 19c1790 into release/5.10 Sep 29, 2023
@bnbarham bnbarham deleted the egorzhdan/5.10-revert-nsnotificationname branch September 29, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@egorzhdan @DougGregor @bnbarham