Skip to content

Update Changelog to include SE-0080 #6877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2017

Conversation

ultramiraculous
Copy link
Contributor

@ultramiraculous ultramiraculous commented Jan 18, 2017

Resolves SR-1491.

@CodaFi
Copy link
Contributor

CodaFi commented Jan 18, 2017

I don't think we ever PR'd this into 3.1-branch if you want to cherry-pick it over.

@ultramiraculous
Copy link
Contributor Author

Ah, weird. I must have mis-used GitHub's UI b/c I swear it looked like it was picked already. I'll make another PR.

@CodaFi
Copy link
Contributor

CodaFi commented Jan 18, 2017

The first 3/4ths got picked up, but I don't remember seeing the last one I reviewed.

@ultramiraculous
Copy link
Contributor Author

I just checked out swift-3.1-branch and it looks like the merge commit for that last PR (883ca16) is part of it.

@ultramiraculous
Copy link
Contributor Author

Based on @jtbandes over here. It seems like there was a merge from master into 3.1?

@jtbandes
Copy link
Contributor

(copied from swiftlang/swift-evolution#586)
Just tested the 1/17 snapshot from https://swift.org/download/#snapshots; it looks like Float->Int is still not there, although the changes appear in https://github.com/apple/swift/commits/swift-3.1-branch/stdlib/public/core/FloatingPointTypes.swift.gyb. Perhaps the next snapshot will have it.

@slavapestov
Copy link
Contributor

@swift-ci Please smoke test

@slavapestov
Copy link
Contributor

@ultramiraculous Since the change is in 3.1, do you mind preparing a PR for swift-3.1-branch updating the CHANGELOG there as well?

@slavapestov slavapestov self-assigned this Jan 18, 2017
@jtbandes
Copy link
Contributor

@slavapestov Can you confirm whether this will actually be in 3.1? As mentioned in the comment I noticed the nightly didn't actually have the float->int versions yet.

@slavapestov
Copy link
Contributor

It looks like Linux pull request testing is broken right now because of an unrelated lldb issue. I'll merge this when things are cleared up.

@slavapestov
Copy link
Contributor

@swift-ci Please smoke test

@slavapestov slavapestov merged commit eb3609e into swiftlang:master Jan 19, 2017
@slavapestov
Copy link
Contributor

Hi @ultramiraculous, I looked and all your changes are in swift-3.1-branch (except this CHANGELOG update of course). Mind creating a new PR to cherry-pick it over?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants