-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Update Changelog to include SE-0080 #6877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I don't think we ever PR'd this into 3.1-branch if you want to cherry-pick it over. |
Ah, weird. I must have mis-used GitHub's UI b/c I swear it looked like it was picked already. I'll make another PR. |
The first 3/4ths got picked up, but I don't remember seeing the last one I reviewed. |
I just checked out |
(copied from swiftlang/swift-evolution#586) |
@swift-ci Please smoke test |
@ultramiraculous Since the change is in 3.1, do you mind preparing a PR for swift-3.1-branch updating the CHANGELOG there as well? |
@slavapestov Can you confirm whether this will actually be in 3.1? As mentioned in the comment I noticed the nightly didn't actually have the float->int versions yet. |
It looks like Linux pull request testing is broken right now because of an unrelated lldb issue. I'll merge this when things are cleared up. |
@swift-ci Please smoke test |
Hi @ultramiraculous, I looked and all your changes are in swift-3.1-branch (except this CHANGELOG update of course). Mind creating a new PR to cherry-pick it over? |
Resolves SR-1491.