Skip to content

Add benchmarks for initializing Characters from literals. #6879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2017

Conversation

allevato
Copy link
Member

These benchmarks test both small characters (no more than 63 bits in UTF-8 encoding, packed in an integer) and large characters (more than 63 bits, requiring a retained StringBuffer). They will be submitted first as a baseline against which to compare #6850, which implements performance improvements for initializing characters from literals.

@allevato
Copy link
Member Author

@swift-ci Please benchmark

1 similar comment
@airspeedswift
Copy link
Member

@swift-ci Please benchmark

@airspeedswift
Copy link
Member

@swift-ci Please smoke test

@airspeedswift
Copy link
Member

The benchmark job will fail (bug with CI when we add new benchmarks) but can check the log to confirm the benchmark ran, it's just the comparison with previous that fails.

@gottesmm
Copy link
Contributor

@airspeedswift @shahmishal Perhaps we should add a special benchmark job that just runs the tests. I think we actually might have a preset that does that.

@jrose-apple
Copy link
Contributor

I see no reason why the benchmark job shouldn't just handle newly-added benchmarks.

@airspeedswift
Copy link
Member

I agree, the job should handle new tests and just put N/A for the speedup on the new tests.

Benchmark logs show the new tests are running OK so I think this is OK to merge.

@airspeedswift airspeedswift merged commit 69eb0f6 into swiftlang:master Jan 18, 2017
@allevato allevato deleted the character-benchmarks branch October 11, 2017 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants