Skip to content

[cleanup] Remove demo-tool from the Swift repo and fix find-unused-diagnostics.sh #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 21, 2015
Merged

[cleanup] Remove demo-tool from the Swift repo and fix find-unused-diagnostics.sh #688

merged 2 commits into from
Dec 21, 2015

Conversation

practicalswift
Copy link
Contributor

  • utils/demo-tool seems like a nice general purpose presentation tool but since it is not directly Swift related I suggest removing it from the Swift repo.
  • utils/find-unused-diagnostics.sh was added in 2013 and has been untouched since then. It reads from a file that currently does not exist so I assume this script is not in heavy use any more :-)

@gribozavr
Copy link
Contributor

utils/find-unused-diagnostics.sh is still useful and almost working -- it just needs to be fixed to read from include/swift/AST/Diagnostics*.def instead. It actually finds unused diagnostics, that would be an idea for another PR.

As for utils/demo-tool, I would defer to @krememek and @DougGregor.

@practicalswift practicalswift changed the title [cleanup] Remove demo-tool and find-unused-diagnostics.sh from the Swift repo [cleanup] Remove demo-tool from the Swift repo and fix find-unused-diagnostics.sh Dec 21, 2015
@practicalswift
Copy link
Contributor Author

@gribozavr I've now fixed utils/find-unused-diagnostics.sh. Committed, rebased and pushed.

@gribozavr
Copy link
Contributor

@practicalswift Thanks, still waiting on @krememek on @DougGregor to comment about demo-tool.

@lattner
Copy link
Contributor

lattner commented Dec 21, 2015

demo-tool is dead, feel free to nuke it.

@gribozavr
Copy link
Contributor

Awesome, thanks @lattner!

gribozavr added a commit that referenced this pull request Dec 21, 2015
[cleanup] Remove demo-tool from the Swift repo and fix find-unused-diagnostics.sh
@gribozavr gribozavr merged commit 23ebbbe into swiftlang:master Dec 21, 2015
@practicalswift
Copy link
Contributor Author

@lattner, @gribozavr Thanks for clarifying and thanks for merging! :-)

While hunting for obsolete/abandoned files I ran a quick check for all files that are not referenced from another file in the repo.

These are the non-referenced files:

cmake/modules/FindBSD.cmake
cmake/modules/FindICU.cmake
cmake/modules/FindUUID.cmake
stdlib/public/SDK/Foundation/ExtraStringAPIs.swift
tools/SourceKit/utils/buildbot-package-sourcekit.sh
utils/analyze_deps.rb
utils/cmpcodesize/tests/test_list_function_sizes.py
utils/create-filecheck-test.py
utils/demo-tool
utils/error_enum_to_cases.pl
utils/find-unused-diagnostics.sh
utils/pass-pipeline/scripts/pipeline_generator.py
utils/pass-pipeline/scripts/pipelines_build_script.py
utils/pre-commit-benchmark
utils/resolve-crashes.py
utils/runtime_statistics.d
utils/sil-opt-verify-all-modules.py
utils/submit-benchmark-results

Are there any of the files above that look like candidates for deletion?

@lattner
Copy link
Contributor

lattner commented Dec 21, 2015

I'd suggest asking about this on swift-dev. I don't know what most of those do :-)

freak4pc pushed a commit to freak4pc/swift that referenced this pull request Sep 28, 2022
…armv7s-ios

Exclude armv7 and armv7s from iOS platform
freak4pc pushed a commit to freak4pc/swift that referenced this pull request Sep 28, 2022
freak4pc pushed a commit to freak4pc/swift that referenced this pull request Sep 28, 2022
…fter-arch-changes

[Hotfix] Un-xfail Kingfisher and ReactiveKit after swiftlang#688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants