[Runtime] Wrap _checkGenericRequirements for _instantiateCheckedGenericMetadata #68844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
slavapestov
reviewed
Sep 28, 2023
Azoy
force-pushed
the
gather-no-parameters
branch
from
a410885 to
3ddec4f
Compare
Azoy
changed the title
|
@swift-ci please test |
mikeash
approved these changes
Oct 10, 2023
Azoy
added a commit
to Azoy/swift
that referenced
this pull request
Oct 10, 2023
[Runtime] Wrap _checkGenericRequirements for _instantiateCheckedGenericMetadata
|
I still have some concerns about this change. I commented on the 5.9 PR: #69100 |
Azoy
added a commit
that referenced
this pull request
Oct 11, 2023
Revert "Merge pull request #68844 from Azoy/gather-no-parameters"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, callers to
_gatherGenericParametershad to provide all generic parameters, even non-key ones. This made initializing something like:with
Bpretty awkward because the metadata accessor only has a single parameter (the request) and has 0 key arguments. Teach_gatherGenericParametersto handle callers only passing in the required key generic parameters.