Skip to content

Fix MSVC static assertion failue #6886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2017
Merged

Fix MSVC static assertion failue #6886

merged 1 commit into from
Jan 19, 2017

Conversation

hughbe
Copy link
Contributor

@hughbe hughbe commented Jan 18, 2017

@hughbe
Copy link
Contributor Author

hughbe commented Jan 18, 2017

@swift-ci please smoke test

jrose-apple
jrose-apple approved these changes Jan 18, 2017
View reviewed changes
Copy link
Contributor

@jrose-apple jrose-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange fix for a strange pattern in the first place. Can you leave behind a comment so no one tries to simplify it back?

@hughbe
Copy link
Contributor Author

hughbe commented Jan 19, 2017

@swift-ci please smoke test and merge

@hughbe
Copy link
Contributor Author

hughbe commented Jan 19, 2017

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit 3e3c81c into swiftlang:master Jan 19, 2017
@hughbe hughbe deleted the module-static_assert branch January 19, 2017 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrose-apple jrose-apple jrose-apple approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hughbe @jrose-apple @swift-ci