ASTGen: Expose BumpPtrAllocator as @_spi(BumpPtrAllocator) #68860
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,7 +4,7 @@ import CBasicBridging | |||
| // Needed to use SyntaxTransformVisitor's visit method. | |||
| @_spi(SyntaxTransformVisitor) | |||
| // Needed to use BumpPtrAllocator | |||
| @_spi(RawSyntax) | |||
| @_spi(BumpPtrAllocator) //updated from RawSyntax | |||
There was a problem hiding this comment.
I don't think this comment carries much weight. The _spi(RawSyntax) import was just a temporary measure.
There was a problem hiding this comment.
okay I removed the comment, and made a new commit. please check again. thank you so much for being so patient with me.
AnthonyLatsis
approved these changes
Oct 1, 2023
ChiduAnush
force-pushed
the
changeRawSyntaxToBumpPtrAllocator
branch
from
2d6633e to
8b50a0d
Compare
|
please check, I squashed the 2 commits into one using git rebase interactive. |
AnthonyLatsis
changed the title
|
@swift-ci please smoke test |
|
@swift-ci Please smoke test |
ahoppen
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed @_spi(RawSyntax) import SwiftSyntax in ASTGen.swift to @_spi(BumpPtrAllocator) import SwiftSyntax.
Resolves #68351.
Coupled with swiftlang/swift-syntax#2249.