Set clang module directory correctly with fmodule-file-home-is-cwd #68865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building and importing modules built with `-fmodule-file-home-is-cwd` we should be setting the debug info directory to the current working directory. This matches the behavior in clang: https://reviews.llvm.org/D134911
|
@swift-ci please test |
adrian-prantl
approved these changes
Oct 3, 2023
|
This causes a use-after-free failure on the ASAN bot: https://ci.swift.org/job/oss-swift-incremental-ASAN-RA-macos/4251/consoleText |
|
In the |
|
Ah, didn't realize ASTSourceDescriptor was moving its params in the constructor. I'll put up a change to copy the fields instead. Oh this is actually a use-after-scope issue, will redo without reassigning the Desc function param. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building and importing modules built with
-fmodule-file-home-is-cwdwe should be setting the debug info directory to the current working directory. This matches the behavior in clang: https://reviews.llvm.org/D134911