Rework effects checking to maintain thrown type information. #68898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
When will this be released? |
While here, eliminate some redundancy in the implementation of effects checking be consolidating the logic for computing a `Classification` from a particular expression or other entity.
DougGregor
force-pushed
the
effects-checking-refactor
branch
from
6411063 to
69ec45d
Compare
|
@swift-ci please smoke test |
There is still an active discussion on the Swift Forums about the feature this is working toward (typed throws), and the implementation is nowhere near complete. So it won't be soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While here, eliminate some redundancy in the implementation of effects checking be consolidating the logic for computing a
Classificationfrom a particular expression or other entity.