[Clang importer] When importing a property as accessors, use accessor types #6892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… types. When importing a property as accessor methods (rather than as a property), we were still importing the type of the accessor methods as if they were Swift getters and setters of a property, which (necessarily) homogenizes the types. The homogenization is unnecessary when importing as accessor methods, because the methods are independent, so just import the accessor method types as if the property did not exist. This is particularly useful for maintaining Swift 3 source compatibility for cases where Swift 4 turns a getter/setter pair into a null_resettable property. Fixes rdar://problem/30075571.
jrose-apple
approved these changes
Jan 18, 2017
| - Selector: accessorsOnlyRenamedRetyped | ||
| MethodKind: Instance | ||
| SwiftName: 'renamedAndRetyped()' | ||
| ResultType: 'id _Nonnull' |
There was a problem hiding this comment.
We don't even really need API notes in the test case. The accessors could just be declared explicitly with mismatched types, and everything should Just Work™.
There was a problem hiding this comment.
Call me paranoid, but I want to make sure this whole compatibility cocktail works together.
There was a problem hiding this comment.
Sure, but the opposite is also true—if mismatched types declared in the header file don't work, that's also a bug.
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
|
Only the macOS test matters for this change; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing a property as accessor methods (rather than as a
property), we were still importing the type of the accessor methods as
if they were Swift getters and setters of a property, which
(necessarily) homogenizes the types. The homogenization is unnecessary
when importing as accessor methods, because the methods are
independent, so just import the accessor method types as if the
property did not exist. This is particularly useful for maintaining
Swift 3 source compatibility for cases where Swift 4 turns a
getter/setter pair into a null_resettable property.
Fixes rdar://problem/30075571.