Fix irgen test case that was disabled for a while #6894
Conversation
|
@swift-ci Please smoke test and merge |
aschwaighofer
force-pushed
the
fix_irgen_test_generic_metatypes
branch
from
236ded9 to
c8c0fcb
Compare
|
@swift-ci Please smoke test os x |
|
|
||
| // FIXME: SR-3591 test is failing after being unintentionally disabled for a while | ||
| // REQUIRES: SR3591 | ||
| // REQUIRES: CODEGENERATOR=ARM |
There was a problem hiding this comment.
Looks like now the test requires both x86 and arm so it is still effectively disabled. Can you verify that it gets run?
There was a problem hiding this comment.
It will (should) get run on build-script -i builds.
The test case contains arm target tests.
I will split out the arm tests.
There was a problem hiding this comment.
CODEGENERATOR=ARM and CODEGENERATOR=X86 aren't mutually exclusive. But splitting up the test is probably still a good idea.
There was a problem hiding this comment.
I dislike splitting such tests because it makes it easier for one side to lose coverage. But we don't currently have a better solution for tests that touch multiple code generators. (A new conditional RUN command in lit would help, something like RUN REQUIRES CODEGENERATOR=X86: %swift -target x86_64-apple-macosx10.9 ….)
We now pass whether something is an existential meta type to swift_getDynamicType. SR3591
aschwaighofer
force-pushed
the
fix_irgen_test_generic_metatypes
branch
from
c8c0fcb to
1461827
Compare
|
@swift-ci Please smoke test os x platform |
|
@swift-ci Please smoke test linux platform |
We now pass whether something is an existential meta type to
swift_getDynamicType.
SR3591