Skip to content

Fix llvm-cas tests to match new cmd line argument format #68955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

rastogishubham
Copy link
Contributor

@rastogishubham rastogishubham commented Oct 4, 2023

With swiftlang/llvm-project#7566, we have changed the command line options for llvm-cas. The --data option has been replaced by a cl::positional when using the --ingest option

This PR updates the swift tests that depend on that earlier behavior

@rastogishubham
Copy link
Contributor Author

Please test with following pull request:
swiftlang/llvm-project#7566

@swift-ci please test

@rastogishubham
Copy link
Contributor Author

Please test with following pull request:
swiftlang/llvm-project#7566

@swift-ci please test

@cachemeifyoucan
Copy link
Contributor

It seems swift/main is still on 20221013. Maybe you want to rebase this commit onto rebranch if the cherry-pick only goes to 20230725

Copy link
Contributor

@cachemeifyoucan cachemeifyoucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change target branch to rebranch

@rastogishubham rastogishubham merged commit 01c22b3 into swiftlang:rebranch Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants