TBDGen: Improve the accuracy of swift-api-extract output #68978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adopting this new utility, swift-api-extract more reliably gets the ValueDecl associated with a symbol and therefore reports more accurate availability info.
This ensures that different kinds of declarations with the `@_spi_available` attribute are handled consistently.
By plumbing the currently visited Decl through to APIRecorder we can improve the correctness of API symbol visibility and availability in swift-api-extract output.
tshortli
force-pushed
the
improve-api-extract-accuracy
branch
from
1d90dfa to
80b1f4c
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output of
swift-api-extracthad inaccurate visibility and availability for many symbols becauseAPIRecorderdid not consistently have access to a representativeDeclto query for those attributes. We can plumb the currently visitedDeclthrough fromSILSymbolVisitorto provide more consistent context.