[wasm][stdlib] Don't use <thread> sleep API with swift-threading-package=none #69006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age=none Unfortunately `sleep_until` is defined under <thread> header even though it does not use thread feature at all with `std::chrono::steady_clock`. The <thread> header in libcxx is not available when thread feature is disabled, so we need to fallback to nanosleep for the case.
|
@swift-ci Please smoke test |
MaxDesiatov
approved these changes
Oct 6, 2023
MaxDesiatov
added
standard library
al45tair
approved these changes
Oct 6, 2023
kateinoigakukun
deleted the
pr-0983246048e8181baa144ac66ad3344b4b1b774c
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately
sleep_untilis defined under header even though it does not use thread feature at all withstd::chrono::steady_clock. The header in libcxx is not available when thread feature is disabled, so we need to fallback to nanosleep for the case.Resolves part of rdar://116552886