Skip to content

[test][IRGen] Split out objc-interop specific part in abitypes.swift #69015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kateinoigakukun
Copy link
Member

Split out abitypes.swift into 3 tests, 1 for objc-interop, 2 for x64 argument coercing, 3 for arm layout.
This improves test coverage on non-objc-interopping platforms and eliminates the need to add "XFAIL" when adding new architectures.

@kateinoigakukun kateinoigakukun added test suite Area: test suite IRGen LLVM IR generation labels Oct 6, 2023
@kateinoigakukun
Copy link
Member Author

@swift-ci Please test

@kateinoigakukun kateinoigakukun force-pushed the pr-05be3cf5a211809b2f7bf7bf92adb6809ce4751b branch from 1eec32b to 82d597a Compare October 6, 2023 22:56
@kateinoigakukun
Copy link
Member Author

@swift-ci Please test

@kateinoigakukun kateinoigakukun marked this pull request as ready for review October 7, 2023 04:47
@kateinoigakukun
Copy link
Member Author

@swift-ci Please smoke test Windows platform

@kateinoigakukun kateinoigakukun force-pushed the pr-05be3cf5a211809b2f7bf7bf92adb6809ce4751b branch from 82d597a to 23db49b Compare October 7, 2023 18:22
@kateinoigakukun
Copy link
Member Author

@swift-ci Please smoke test and merge

@swift-ci swift-ci merged commit e11965a into swiftlang:main Oct 7, 2023
@kateinoigakukun kateinoigakukun deleted the pr-05be3cf5a211809b2f7bf7bf92adb6809ce4751b branch October 11, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IRGen LLVM IR generation test suite Area: test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants