-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[test][IRGen] Split windows autolink checks into a separate file #69062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test][IRGen] Split windows autolink checks into a separate file #69062
Conversation
@swift-ci Please smoke test |
f6c30a1
to
bc4ce55
Compare
@swift-ci Please smoke test |
%target-cpu
in -target valueThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain how the invalid triples are formed? I don't immediately see how that would happen.
@compnerd The invalid triple can be formed when running test/IRGen suite on a build dir which is configured for cross compiling (especially I'm cross compiling for wasm32 on linux/macos) |
Since it can construct invalid target triples like wasm32-unknown-windows-msvc, which can hit internal compiler crash in llvm. So split into a separate file to run the test only on archs windows supports.
bc4ce55
to
4ab3620
Compare
@swift-ci Please smoke test |
@swift-ci test macos |
Presumably it's this:
since when building for WASM presumably |
@compnerd Let me know if you still have any concern about merging this 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bah, I missed the %target-cpu-unknown-windows-msvc
.
Since it can construct invalid target triples like wasm32-unknown-windows-msvc, which can hit internal compiler crash in llvm. So split into a separate file to run the test only on archs windows supports.