Skip to content

[Test] Print to stdout. #69080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

nate-chandler
Copy link
Contributor

In the C++ sources it is slightly more convenient to dump to stderr than to print to stdout, but it is rather more unpleasant to print to stderr from the Swift sources. Switch to stdout. Also allows the dump functions to be marked debug only.

@nate-chandler nate-chandler requested a review from atrick October 9, 2023 23:08
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler nate-chandler marked this pull request as ready for review October 9, 2023 23:52
@nate-chandler
Copy link
Contributor Author

@swift-ci please smoke test and merge

Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

In the C++ sources it is slightly more convenient to dump to stderr than
to print to stdout, but it is rather more unsightly to print to stderr
from the Swift sources.  Switch to stdout.  Also allows the dump
functions to be marked debug only.
@nate-chandler nate-chandler force-pushed the test/20231009/1/stdout branch from d1d7547 to 9ca6b9a Compare October 10, 2023 15:19
@nate-chandler
Copy link
Contributor Author

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit db2a306 into swiftlang:main Oct 10, 2023
@nate-chandler nate-chandler deleted the test/20231009/1/stdout branch October 10, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants