[Concurrency] Fix a few issues with actor-isolated inout argument diagnostics.
#69083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hborla
requested review from
ktoso,
kavon,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
…iagnostics. ActorIsolationChecker's apply stack was not considering LookupExpr, which caused bogus diagnostics for inout arguments that happen to be subexpressions of async function calls. Similarly, inout arguments to async subscript calls were not diagnosed because the subscript application was not tracked in the apply stack. There's still an issue with async computed getter calls because the type-checked AST does not have an InOutExpr for the base expression.
hborla
force-pushed
the
inout-async-error
branch
from
1e683a6 to
17ac5fe
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Windows |
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActorIsolationChecker's apply stack was not consideringLookupExpr, which caused bogus diagnostics forinoutarguments that happen to be subexpressions ofasyncfunction calls. Similarly,inoutarguments toasyncsubscript calls were not diagnosed because the subscript application was not tracked in the apply stack.There's still an issue with
asynccomputed getter calls because the type-checked AST does not have anInOutExprfor the base expression.Resolves rdar://115863944, resolves #60302, resolves #59583.