Skip to content

[5.10][SE-0404] Allow protocols to be nested in non-generic contexts #69103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

karwa
Copy link
Contributor

@karwa karwa commented Oct 10, 2023

Cherry-pick of #66247

  • Explanation: Implements SE-0404
  • Scope: Swift Compiler (no runtime or stdlib changes)
  • Risk: Medium
  • Testing: Passes the current test suite
  • Reviewer: Slava Pestov (@slavapestov)

@karwa karwa requested a review from a team as a code owner October 10, 2023 19:49
@slavapestov
Copy link
Contributor

I think this is a low risk change and we should take it since the proposal was accepted already. It's unlikely to change the type checking behavior of any existing valid code.

@hborla
Copy link
Member

hborla commented Oct 10, 2023

@swift-ci please test

@slavapestov slavapestov merged commit e4400bc into swiftlang:release/5.10 Oct 11, 2023
@karwa karwa deleted the nested-protocol-5-10 branch October 11, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants