[5.10][SILGen/DI] InitAccessors: Fix handling of nonmutating set when type has other stored properties
#69104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The closure with applied base is not escaping and gets applied only once (when self is fully initialized). Let's make sure that the partial application results in on-stack closure that borrows "self" instead of copying it. (cherry picked from commit ab54ea7)
…sign_by_wrapper` For cases where init accessor field has a nonmutating set we need ignore copies and borrows associated with load of "self" because they are going to be erased together with the setter application by DI. (cherry picked from commit 24c4fcc)
(cherry picked from commit 3414609)
|
@swift-ci please test |
hborla
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #68875
The original change supported only the case where all stored properties were controlled
by an init accessor but when other fields were involved SILGen would emitted copies of
loaded "self" for each setter application which is redundant and due to the fact that the
setter was escaping.
These changes make partial application of the setter non-escaping which means that
"self" can be borrowed instead of copied.
Scope: Init accessor declarations with
nonmutating setused in default initializers mixed with other stored properties.Main Branch PR: [SILGen/DI] InitAccessors: Fix handling of
nonmutating setwhen type has other stored properties #68875Resolves: Init accessor with non mutating set results in compiler error #67827
Risk: Low
Reviewed By: @jckarter
Testing: SILGen and Interpreter tests added to the test suite.