[3.1] IRGen: Don't try to emit non-global variables of imported inline c functions #6913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nctions The previous check would fail because isExternallyVisible() is false for local static variables with internal linkage. rdar://29937443
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous check would fail because isExternallyVisible() is false for local
static variables with internal linkage.
rdar://29937443
• Explanation: We would assert during IRGen of imported inline C functions which had a static local variable with the internal linkage attribute set because we would try to generate code for this local variable.
• Scope of Issue: Occurs in swift code that imports inline c functions which static local variables that are marked internal_linkage.
• Origination: Unknown (the code with the wrong check has been there since 2014)
• Risk: Low.
• Reviewed By: John McCall
• Testing: Swift CI