[5.10] Provide ability to use CheckedContinuation when suspending for an async ObjC call #69139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…handler generator Instead of relying on `continuationType` for information, let's take it from the source. (cherry picked from commit a602531)
…to checked continuations (cherry picked from commit b8fb94b)
… `CheckedContinuation` (cherry picked from commit 6e48d44)
Because `CheckedContinuation` is not a @Frozen struct we have to use `Any` to store it in @block_storage indirectly. If the flag is enabled, we'd emit a block storage with `Any` and initialize the existential with stack allocated `CheckedContinuation` formed from `UnsafeContinuation`. Inside of the completion handler `Any` is going to be projected and cast back to `CheckedContinuation`. (cherry picked from commit 4b22620)
…t's using async continuations (cherry picked from commit 7d6c4b7)
…king continuations mode (cherry picked from commit 6ecbb08)
(cherry picked from commit ce651ca)
|
@swift-ci please test |
hborla
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #68390
To provide enhanced debugging and runtime checking for the correct usage
of continuations passed in a call to ObjC from Swift, this PR introduces a flag
for the
swift-frontendthat uses aCheckedContinuationwhen calling anasync ObjC function from Swift. When enabled, the underlying block value
passed as a completion-handler is created using
CheckedContinuationinstead of just an
UnsafeContinuation, which was what was used previously.The checked continuation ensures that the block is only invoked once.
As of now, the
swift-frontendflag is-checked-async-objc-bridging={on, off}Scope: Calls to ObjC with async handlers.
Main Branch PR: Provide ability to use CheckedContinuation when suspending for an async ObjC call #68390
Resolves: rdar://89930501
Risk: Low
Reviewed By: @ktoso @jckarter
Testing: added test-cases to the test suite.