[5.10] Reduce rebuilds when running buildbot_incremental presets in succession #69168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uccession We have some configurations in which we run a preset that only builds the compiler, and then a few ones to tests such binary, e.g. ``` buildbot_incremental,tools=RA,stdlib=RD,build buildbot_incremental,tools=RA,stdlib=RD,test=macOS,type=device buildbot_incremental,tools=RA,stdlib=RD,test=iOS,type=simulator buildbot_incremental,tools=RA,stdlib=RD,test=watchOS,type=simulator ``` Contrary to the other presets, in the first preset we did not specify "--lit-args" since it is not necessary -- however that plays a part in the configuration of compiler-rt, causing an unwanted rebuild when that parameter is specified in the following preset. Addresses rdar://116922016 (cherry picked from commit 6cf157e)
|
@swift-ci please test |
edymtt
changed the title
shahmishal
approved these changes
Oct 13, 2023
|
@swift-ci please build toolchain |
|
@swift-ci please build toolchain macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: explicitly set
lit-argsforbuildbot_incremental,*,buildpresets, so that when we run matchingbuildbot_incremental,*,test=on the same build folder we don't have any unnecessary rebuilds in LLVMRadar: rdar://116922016
Scope:
buildbot_incremental,*,buildpresetsRisk: low
buildbot_incremental,*,testpresets are currently specifying the same value forlit-argsTesting: run at desk a build of
buildbot_incremental,tools=RA,stdlib=RD,buildfollowed bybuildbot_incremental,tools=RA,stdlib=RD,test=macOS,type=device, and checked there is no rebuild of compiler-rtReviewed by:
(cherry picked from commit 6cf157e)